Don't count the wrong things #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oes not include the vap and bgpsec keys. As a result reloadFromCurrentState() gets utterly confused and creates new versions when there is no change. Fix for bgp#114
|
Is my read correct that the only use left for |
|
Yes, pretty much. |
|
...and the test. I would almost remove it, since you can mistake it with some of the other ints in the result, with bad results. |
|
Right now this fixes a real bug. Removing more is always possible but should be a step on top of this. |
ties
approved these changes
Feb 29, 2024
To me addressing that was well would remove the root cause of the bug as well. But this fixes a real bug as is, so lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count in processData() makes little sense as a return value, one can count the various slices with len() just as easily.
Especially since it does not include the vap and bgpsec keys.
As a result reloadFromCurrentState() gets utterly confused and creates new versions when there is no change.
Fix for #114